]> git.ipfire.org Git - thirdparty/linux.git/commit
drm/msm/dpu: reorder pointer operations after sanity checks to avoid NULL deref
authorQasim Ijaz <qasdev00@gmail.com>
Tue, 8 Apr 2025 17:22:23 +0000 (18:22 +0100)
committerAbhinav Kumar <quic_abhinavk@quicinc.com>
Thu, 10 Apr 2025 20:22:12 +0000 (13:22 -0700)
commit2a34496fef841e8d89a4ccd1a48c7fd664b5c84f
tree99bc9c182c59484f65c9418cfad9b941bddfc45f
parent5cb1b130e1cd04239cc9c26a98279f4660dce583
drm/msm/dpu: reorder pointer operations after sanity checks to avoid NULL deref

_dpu_encoder_trigger_start dereferences "struct dpu_encoder_phys *phys"
before the sanity checks which can lead to a NULL pointer dereference if
phys is NULL.

Fix this by reordering the dereference after the sanity checks.

Fixes: 8144d17a81d9 ("drm/msm/dpu: Skip trigger flush and start for CWB")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Qasim Ijaz <qasdev00@gmail.com>
Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/647536/
Link: https://lore.kernel.org/r/20250408172223.10827-1-qasdev00@gmail.com
Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c