]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
better lockdep annotations for simple_recursive_removal()
authorAl Viro <viro@zeniv.linux.org.uk>
Thu, 3 Jul 2025 02:30:32 +0000 (22:30 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Thu, 3 Jul 2025 02:30:32 +0000 (22:30 -0400)
commit2a8061ee5e41034eb14170ec4517b5583dbeff9f
tree7cc2a67fdd029a42600c728451305b2d8fce6ad1
parent61c5d53e815784708c45dac086c50a12ed1db694
better lockdep annotations for simple_recursive_removal()

We want a class that nests outside of I_MUTEX_NORMAL (for the sake of
callbacks that might want to lock the victim) and inside I_MUTEX_PARENT
(so that a variant of that could be used with parent of the victim
held locked by the caller).

In reality, simple_recursive_removal()
* never holds two locks at once
* holds the lock on parent of dentry passed to callback
* is used only on the trees with fixed topology, so the depths
are not changing.

So the locking order is actually fine.

AFAICS, the best solution is to assign I_MUTEX_CHILD to the locks
grabbed by that thing.

Reported-by: syzbot+169de184e9defe7fe709@syzkaller.appspotmail.com
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/libfs.c