]> git.ipfire.org Git - thirdparty/fcron.git/commit
Feature/fix email From: w/ configurable "displayname" (#17)
authorMarco Emilio "sphakka" Poleggi <7766137+sphakka@users.noreply.github.com>
Sat, 24 Aug 2024 15:36:38 +0000 (17:36 +0200)
committerGitHub <noreply@github.com>
Sat, 24 Aug 2024 15:36:38 +0000 (16:36 +0100)
commit2b18ac9cd8647dd32367fdf07eafa24c51cbe410
tree44eba0197208f5122577e46b98f170afadb5a8c0
parent8236ae2c41a47c6fbd23262a6fd07a803e57681e
Feature/fix email From: w/ configurable "displayname" (#17)

* WIP: add displayname option

Signed-off-by: Marco Emilio "sphakka" Poleggi <7766137+sphakka@users.noreply.github.com>
* Fix configure.in

Signed-off-by: Marco Emilio "sphakka" Poleggi <7766137+sphakka@users.noreply.github.com>
* Restored orig configure.in + displayname opt

Signed-off-by: Marco Emilio "sphakka" Poleggi <7766137+sphakka@users.noreply.github.com>
* job.c: create_mail():

Process 'displayname', etc. via new function 'make_mailbox()' as per RFC5322.

Signed-off-by: Marco Emilio "sphakka" Poleggi <7766137+sphakka@users.noreply.github.com>
* Fixed wrong formatting (tabs => spaces)

Signed-off-by: Marco Emilio "sphakka" Poleggi <7766137+sphakka@users.noreply.github.com>
* dev(code, doc, test): displayname handling refactored over two functions.

* code: config handling of displayname moved to a new function
  'format_displayname()' in 'fcronconf.c'; buffer overflow check added. In
  'job.c': restored old "From:" mail header behavior if no displayname; buffer
  overflow check added.
* test: added prototype support in 'Makefile' and 'test/'
* doc: reviewed and cleaned 'en/fcron.conf.5.sgml'

Signed-off-by: Marco Emilio "sphakka" Poleggi <7766137+sphakka@users.noreply.github.com>
* dev(code, test): @PR #17, 3rd round.

* Makefile(s): fixed alignement with spaces
* config.in: moved displayname in "Check for fcron..." section. Removed test
    install code.
* fcronconf.c: changed format_displayname()'s arg to avoid confusion with
    globals. Use stdbool. Use aux var when assigning from
    format_displayname().
* crondyn_svr.c, fileconf.c: minimal fixes to avoid conflict with stdbool.
* fcron.conf.in: added comment for possible displayname's future default value.
* global.h: added stdbool.
* job.c: changed make_mailbox_addr()'s arg to avoid confusion with
    globals. Use stdbool.
* test/mailbox_addr.c: rewritten with simpler explicit logic -- valgrinded
    again ;-)

Signed-off-by: Marco Emilio "sphakka" Poleggi <7766137+sphakka@users.noreply.github.com>
---------

Signed-off-by: Marco Emilio "sphakka" Poleggi <7766137+sphakka@users.noreply.github.com>
14 files changed:
Makefile.in
configure.in
doc/en/fcron.conf.5.sgml
doc/fcron-doc.mod.in
fcronconf.c
fcronconf.h
fcrondyn_svr.c
fileconf.c
files/fcron.conf.in
global.h
job.c
job.h
test/Makefile.in [new file with mode: 0644]
test/mailbox_addr.c [new file with mode: 0644]