]> git.ipfire.org Git - thirdparty/linux.git/commit
EDAC/i10nm: Fix the bitwise operation between variables of different sizes
authorQiuxu Zhuo <qiuxu.zhuo@intel.com>
Thu, 24 Apr 2025 08:14:54 +0000 (16:14 +0800)
committerTony Luck <tony.luck@intel.com>
Thu, 24 Apr 2025 15:42:25 +0000 (08:42 -0700)
commit2b2408aca90b86c1ef51c19d834e5f6db0a1ff30
tree9db57f634d5b25c7ef9fc8231ff4144452a8dd00
parent180f091224a002f8bd1629307c34619a5626841e
EDAC/i10nm: Fix the bitwise operation between variables of different sizes

The tool of Smatch static checker reported the following warning:

  drivers/edac/i10nm_base.c:364 show_retry_rd_err_log()
  warn: should bitwise negate be 'ullong'?

This warning was due to the bitwise NOT/AND operations between
'status_mask' (a u32 type) and 'log' (a u64 type), which resulted in
the high 32 bits of 'log' were cleared.

This was a false positive warning, as only the low 32 bits of 'log' was
written to the first RRL memory controller register (a u32 type).

To improve code sanity, fix this warning by changing 'status_mask' to
a u64 type, ensuring it matches the size of 'log' for bitwise operations.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/aAih0KmEVq7ch6v2@stanley.mountain/
Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Link: https://lore.kernel.org/r/20250424081454.2952632-1-qiuxu.zhuo@intel.com
drivers/edac/i10nm_base.c