]> git.ipfire.org Git - thirdparty/glibc.git/commit
support: Increase usability of TEST_COMPARE
authorFlorian Weimer <fweimer@redhat.com>
Mon, 8 Jan 2018 12:01:36 +0000 (13:01 +0100)
committerFlorian Weimer <fweimer@redhat.com>
Mon, 8 Jan 2018 19:07:24 +0000 (20:07 +0100)
commit2b3aa44656dd873e2753c98fdcb95be6a9d147a6
tree7c6df54631968d08cc407487b20b93c5123baac6
parent630f4cc3aa019ede55976ea561f1a7af2f068639
support: Increase usability of TEST_COMPARE

The previous implementation of the TEST_COMPARE macro would fail
to compile code like this:

  int ret = res_send (query, sizeof (query), buf, sizeof (buf));
  TEST_COMPARE (ret,
                sizeof (query)
                + 2             /* Compression reference.  */
                + 2 + 2 + 4 + 2 /* Type, class, TTL, RDATA length.  */
                + 1             /* Pascal-style string length.  */
                + strlen (expected_name));

This resulted in a failed static assertion, "integer conversions
may alter sign of operands".  A user of the TEST_COMPARE would have
to add a cast to fix this.

This patch reverts to the original proposed solution of a run-time
check, making TEST_COMPARE usable for comparisons of numbers with
types with different signedness in more contexts.
ChangeLog
support/check.h
support/support_test_compare_failure.c
support/tst-test_compare.c