]> git.ipfire.org Git - people/ms/linux.git/commit
kvm: don't take vcpu mutex for obviously invalid vcpu ioctls
authorDavid Matlack <dmatlack@google.com>
Fri, 19 Sep 2014 23:03:25 +0000 (16:03 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Oct 2014 16:43:06 +0000 (09:43 -0700)
commit2b40b3639fdcf9dd39b13389243f7c2c46cd87bd
tree0c2ce495bf700208a4b6c3e80083776b4e21672a
parent30d863aa7a742129a7b964e61ae92b812eb4eb88
kvm: don't take vcpu mutex for obviously invalid vcpu ioctls

commit 2ea75be3219571d0ec009ce20d9971e54af96e09 upstream.

vcpu ioctls can hang the calling thread if issued while a vcpu is running.
However, invalid ioctls can happen when userspace tries to probe the kind
of file descriptors (e.g. isatty() calls ioctl(TCGETS)); in that case,
we know the ioctl is going to be rejected as invalid anyway and we can
fail before trying to take the vcpu mutex.

This patch does not change functionality, it just makes invalid ioctls
fail faster.

Signed-off-by: David Matlack <dmatlack@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
virt/kvm/kvm_main.c