]> git.ipfire.org Git - people/ms/linux.git/commit
netfilter: ctnetlink: fix dumping of dying/unconfirmed conntracks
authorPablo Neira Ayuso <pablo@netfilter.org>
Thu, 5 Jun 2014 12:28:44 +0000 (14:28 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 9 Jul 2014 18:21:31 +0000 (11:21 -0700)
commit2b4ba2df0337d3d8d0a1ae3bcf9a73e947b68cdd
tree41d1b4e9edeb4fabebb49eba7121092f45ecfa29
parent6442220792dfa623e8e0d98a5a6b4af4aa456fb9
netfilter: ctnetlink: fix dumping of dying/unconfirmed conntracks

commit 266155b2de8fb721ae353688529b2f8bcdde2f90 upstream.

The dumping prematurely stops, it seems the callback argument that
indicates that all entries have been dumped is set after iterating
on the first cpu list. The dumping also may stop before the entire
per-cpu list content is also dumped.

With this patch, conntrack -L dying now shows the dying list content
again.

Fixes: b7779d06 ("netfilter: conntrack: spinlock per cpu to protect special lists.")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/netfilter/nf_conntrack_netlink.c