]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/ide/piix: properly initialize the BMIBA register
authorOlaf Hering <olaf@aepfle.de>
Wed, 12 Jul 2023 07:47:22 +0000 (09:47 +0200)
committerMichael Tokarev <mjt@tls.msk.ru>
Sat, 15 Jul 2023 07:01:15 +0000 (10:01 +0300)
commit2b6a75b78e5f6ec89a640a29379c749ca2651610
tree253ab6e1682865777ee9597897102659c3b6b84b
parent681858ea14242d3b509b77e0179f7f63c99032bb
hw/ide/piix: properly initialize the BMIBA register

According to the 82371FB documentation (82371FB.pdf, 2.3.9. BMIBA-BUS
MASTER INTERFACE BASE ADDRESS REGISTER, April 1997), the register is
32bit wide. To properly reset it to default values, all 32bit need to be
cleared. Bit #0 "Resource Type Indicator (RTE)" needs to be enabled.

The initial change wrote just the lower 8 bit, leaving parts of the "Bus
Master Interface Base Address" address at bit 15:4 unchanged.

Fixes: e6a71ae327 ("Add support for 82371FB (Step A1) and Improved support for 82371SB (Function 1)")
Signed-off-by: Olaf Hering <olaf@aepfle.de>
Reviewed-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20230712074721.14728-1-olaf@aepfle.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
(cherry picked from commit 230dfd9257e92259876c113e58b5f0d22b056d2e)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/ide/piix.c