]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
qed: fix double free in qed_cxt_tables_alloc()
authorDawei Feng <dawei.feng@seu.edu.cn>
Wed, 20 May 2026 07:03:23 +0000 (15:03 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 21 May 2026 15:15:00 +0000 (08:15 -0700)
commit2bccfb8476ca5f3548afbd623dc7a6980d4e77de
treec64e54801d1a5233336de02a480795147c35ae06
parentb809d0409991b75a6cff846a5ac27c3062953f84
qed: fix double free in qed_cxt_tables_alloc()

If one of the later PF or VF CID bitmap allocations fails,
qed_cid_map_alloc() jumps to cid_map_fail and frees the previously
allocated CID bitmaps before returning an error. qed_cxt_tables_alloc()
then calls qed_cxt_mngr_free(), which invokes qed_cid_map_free()
again.

Fix this by setting each CID bitmap pointer to NULL after bitmap_free()
to avoid double free.

The bug was first flagged by an experimental analysis tool we are
developing for kernel memory-management bugs while analyzing
v6.13-rc1. The tool is still under development and is not yet publicly
available. Manual inspection confirms that the bug is still
present in v7.1-rc3.

Runtime reproduction was not attempted because exercising the failing
allocation path requires device-specific setup.

Fixes: fe56b9e6a8d9 ("qed: Add module with basic common support")
Cc: stable@vger.kernel.org
Signed-off-by: Zilin Guan <zilin@seu.edu.cn>
Signed-off-by: Dawei Feng <dawei.feng@seu.edu.cn>
Link: https://patch.msgid.link/20260520070323.2762379-1-dawei.feng@seu.edu.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/qlogic/qed/qed_cxt.c