]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/amdkfd: fix NULL dereference in get_queue_ids()
authorMuhammad Bilal <meatuni001@gmail.com>
Sat, 23 May 2026 16:56:46 +0000 (16:56 +0000)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 3 Jun 2026 18:54:28 +0000 (14:54 -0400)
commit2bd550b547deabef98bd3b017ff743b7c34d3a6d
tree8fec43b557b5d9116b8593cd145fbee3de9dc355
parente47b0056a08dc70430ffc44bbf62197e7d1ff8ea
drm/amdkfd: fix NULL dereference in get_queue_ids()

When usr_queue_id_array is NULL and num_queues is non-zero,
get_queue_ids() returns NULL. The callers check only IS_ERR() on the
return value; since IS_ERR(NULL) == false the check passes, and
suspend_queues() calls q_array_invalidate() which immediately
dereferences NULL while iterating num_queues times.

Userspace can trigger this via kfd_ioctl_set_debug_trap() by supplying
num_queues > 0 with a zero queue_array_ptr, causing a kernel panic.

A NULL usr_queue_id_array with num_queues == 0 is a legitimate no-op
(q_array_invalidate never executes, and resume_queues already guards
all queue_ids dereferences behind a NULL check). Return ERR_PTR(-EINVAL)
only when num_queues is non-zero and the pointer is absent; both callers
already propagate IS_ERR() returns correctly to userspace.

Fixes: a70a93fa568b ("drm/amdkfd: add debug suspend and resume process queues operation")
Signed-off-by: Muhammad Bilal <meatuni001@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit f165a82cdf503884bb1797771c61b2fcc72113d4)
Cc: stable@vger.kernel.org
drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c