]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Heed lock protocol in DROP OWNED BY
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Wed, 6 May 2020 16:29:41 +0000 (12:29 -0400)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Wed, 6 May 2020 16:29:41 +0000 (12:29 -0400)
commit2bf56f50ebb0c9ce2416b27a640cf61488b5ed89
tree8ccf0abd382e7daf31798bbfd48516334243848f
parente07fdc126ef3c75dedd279f87c3be6e8eed5543d
Heed lock protocol in DROP OWNED BY

We were acquiring object locks then deleting objects one by one, instead
of acquiring all object locks first, ignoring those that did not exist,
and then deleting all objects together.   The latter is the correct
protocol to use, and what this commits changes to code to do.  Failing
to follow that leads to "cache lookup failed for relation XYZ" error
reports when DROP OWNED runs concurrently with other DDL -- for example,
a session termination that removes some temp tables.

Author: Álvaro Herrera
Reported-by: Mithun Chicklore Yogendra (Mithun CY)
Reviewed-by: Ahsan Hadi, Tom Lane
Discussion: https://postgr.es/m/CADq3xVZTbzK4ZLKq+dn_vB4QafXXbmMgDP3trY-GuLnib2Ai1w@mail.gmail.com
src/backend/catalog/dependency.c
src/backend/catalog/pg_shdepend.c
src/include/catalog/dependency.h