]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Don't clear btpo_cycleid during _bt_vacuum_one_page.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 21 Feb 2012 20:04:01 +0000 (15:04 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 21 Feb 2012 20:04:01 +0000 (15:04 -0500)
commit2c293f25494f2d465bcff49d7aab6ec06a40e436
tree0bc003ffc19c5a9576fb8a4c9ee61fb398e0f97a
parentf3ad4ca00e1f63357751d855a9150d3ba404a2b2
Don't clear btpo_cycleid during _bt_vacuum_one_page.

When "vacuuming" a single btree page by removing LP_DEAD tuples, we are not
actually within a vacuum operation, but rather in an ordinary insertion
process that could well be running concurrently with a vacuum.  So clearing
the cycleid is incorrect, and could cause the concurrent vacuum to miss
removing tuples that it needs to remove.  This is a longstanding bug
introduced by commit e6284649b9e30372b3990107a082bc7520325676 of
2006-07-25.  I believe it explains Maxim Boguk's recent report of index
corruption, and probably some other previously unexplained reports.

In 9.0 and up this is a one-line fix; before that we need to introduce a
flag to tell _bt_delitems what to do.
src/backend/access/nbtree/nbtinsert.c
src/backend/access/nbtree/nbtpage.c
src/backend/access/nbtree/nbtree.c
src/include/access/nbtree.h