]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Only update frame calculation if we have a valid link sockets
authorArne Schwabe <arne@rfc2549.org>
Wed, 1 Mar 2023 13:44:55 +0000 (14:44 +0100)
committerGert Doering <gert@greenie.muc.de>
Mon, 20 Mar 2023 16:38:01 +0000 (17:38 +0100)
commit2d17869f8d9d8e27f64f1a7cd1514fbbb768807b
treef78e340a6f36453271d370fe19bc6e4817aee333
parenta261e173341f8e68505a6ab5a413d09b0797a459
Only update frame calculation if we have a valid link sockets

Without this, we will caculate a pointer to the linksocket relative to a
null pointer in get_link_socket_info(), which itself does not crash and
the pointer seems not to be accessed later, so we do not get a crash here.

This is still not the correct behaviour and the undefined behaviour
sanitiser from llvm/clang finds this.

Change-Id: I82a20ac72f60f8770ea1b4ab0c8cdea31868abe7
Signed-off-by: Arne Schwabe <arne@rfc2549.org>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20230301134455.2810114-1-arne@rfc2549.org>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26318.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/init.c