]> git.ipfire.org Git - thirdparty/xz.git/commit
ci: test Valgrind
authorSam James <sam@gentoo.org>
Wed, 10 Apr 2024 10:43:10 +0000 (11:43 +0100)
committerLasse Collin <lasse.collin@tukaani.org>
Wed, 22 May 2024 11:26:59 +0000 (14:26 +0300)
commit2d2d5f14b392cd1aeddab7ce34fd50ba5422e5b5
treef414f82eee72d5c6e5adda8b05393c84eceead45
parent5d20a612051fac3ca6d99abe3cd7e0e3370e5b67
ci: test Valgrind

Using `--trace-children=yes` has a trade-off here, as it makes
`test_scripts.sh` pretty slow when calling various non-xz utilities.

But I also feel like it's not useless to have Valgrind used there and it's
not easy to exclude Valgrind just for that one test...

I did consider using AX_VALGRIND_CHECK [0][1] but I couldn't get it working
immediately with some conditionally-built tests and I wondered if it was
worth spending time on at least while we're debating xz's future build
system situation.

[0] https://www.gnu.org/software/autoconf-archive/ax_valgrind_check.html
[1] https://tecnocode.co.uk/2014/12/23/automatically-valgrinding-code-with-ax_valgrind_check/

(cherry picked from commit 6c095a98fbec70b790253a663173ecdb669108c4)
.github/workflows/ci.yml
build-aux/ci_build.sh