]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Drop slot's LWLock before returning from SaveSlotToPath()
authorPeter Eisentraut <peter@eisentraut.org>
Thu, 26 Mar 2020 10:51:39 +0000 (11:51 +0100)
committerPeter Eisentraut <peter@eisentraut.org>
Thu, 26 Mar 2020 13:01:56 +0000 (14:01 +0100)
commit2d8597ba66a1646e353c0ff755b4b0b85cd1747f
treecc849609d96b9457f2f62710addbeae7e1769fcb
parentef7f01a50489efdf5f6fd2f352853d2deb6c3e5e
Drop slot's LWLock before returning from SaveSlotToPath()

When SaveSlotToPath() is called with elevel=LOG, the early exits didn't
release the slot's io_in_progress_lock.

This could result in a walsender being stuck on the lock forever.  A
possible way to get into this situation is if the offending code paths
are triggered in a low disk space situation.

Author: Pavan Deolasee <pavan.deolasee@2ndquadrant.com>
Reported-by: Craig Ringer <craig@2ndquadrant.com>
Discussion: https://www.postgresql.org/message-id/flat/56a138c5-de61-f553-7e8f-6789296de785%402ndquadrant.com
src/backend/replication/slot.c