]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/amd/display: fix the ability to use lower resolution modes on eDP
authorHamza Mahfooz <hamza.mahfooz@amd.com>
Wed, 13 Sep 2023 18:48:08 +0000 (14:48 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 20 Sep 2023 21:28:34 +0000 (17:28 -0400)
commit2de19022c5d7ff519dd5b9690f7713267bd1abfe
treee8a80da2307885eb5bd6024483012d231dab15d6
parentf387bb578d49c5bf24204810cb2721f151d3eee2
drm/amd/display: fix the ability to use lower resolution modes on eDP

On eDP we can receive invalid modes from dm_update_crtc_state() for
entirely new streams for which drm_mode_set_crtcinfo() shouldn't be
called on. So, instead of calling drm_mode_set_crtcinfo() from within
create_stream_for_sink() we can instead call it from
amdgpu_dm_connector_mode_valid(). Since, we are guaranteed to only call
drm_mode_set_crtcinfo() for valid modes from that function (invalid
modes are rejected by that callback) and that is the only user
of create_validate_stream_for_sink() that we need to call
drm_mode_set_crtcinfo() for (as before commit cb841d27b876
("drm/amd/display: Always pass connector_state to stream validation"),
that is the only place where create_validate_stream_for_sink()'s
dm_state was NULL).

Cc: stable@vger.kernel.org
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2693
Fixes: cb841d27b876 ("drm/amd/display: Always pass connector_state to stream validation")
Tested-by: Mark Broadworth <mark.broadworth@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c