]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Avoid fetching from an already-terminated plan.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 9 Sep 2021 17:36:31 +0000 (13:36 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 9 Sep 2021 17:36:31 +0000 (13:36 -0400)
commit2e75e969c88f51a2dd571540252f6423c936d49c
tree53e1cebd72aa0660e9945c873d51ac8b2cf805e0
parenta7a73ce301715a713954278ae1de36aaf39221ab
Avoid fetching from an already-terminated plan.

Some plan node types don't react well to being called again after
they've already returned NULL.  PortalRunSelect() has long dealt
with this by calling the executor with NoMovementScanDirection
if it sees that we've already run the portal to the end.  However,
commit ba2c6d6ce overlooked this point, so that persisting an
already-fully-fetched cursor would fail if it had such a plan.

Per report from Tomas Barton.  Back-patch to v11, as the faulty
commit was.  (I've omitted a test case because the type of plan
that causes a problem isn't all that stable.)

Discussion: https://postgr.es/m/CAPV2KRjd=ErgVGbvO2Ty20tKTEZZr6cYsYLxgN_W3eAo9pf5sw@mail.gmail.com
src/backend/commands/portalcmds.c