]> git.ipfire.org Git - thirdparty/libvirt.git/commit
Revert "tests: Use qemu:///embed to simplify fakerootdir management"
authorAndrea Bolognani <abologna@redhat.com>
Thu, 7 May 2020 20:31:04 +0000 (22:31 +0200)
committerAndrea Bolognani <abologna@redhat.com>
Thu, 7 May 2020 20:31:04 +0000 (22:31 +0200)
commit2e93af279abd87305eb316e0d64c8b70af57b4dd
treea06a889aaed03f7e3ede73130b5314204ac573f7
parentd98cc1968e7961cb02ed07406451a7b710cc2f24
Revert "tests: Use qemu:///embed to simplify fakerootdir management"

Turns out that it's not enough to pass the qemu:///embed root to
virQEMUDriverConfigNew(), you also have to make sure the same
string is copied into the virQEMUDriver structure yourself, and
not doing so in our case resulted in the cleanup never happening
and in distcheck failing because of that.

On the other hand, actually setting config->embeddedRoot would
result in different paths being generated for each test run, which
would obviously break qemuxml2argvtest, so that's not an option
either.

This reverts commit d98cc1968e7961cb02ed07406451a7b710cc2f24.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
tests/qemuhotplugtest.c
tests/qemumemlocktest.c
tests/qemuxml2argvtest.c
tests/qemuxml2xmltest.c
tests/testutilsqemu.c