]> git.ipfire.org Git - thirdparty/linux.git/commit
btrfs: move file_start_write() to after permission hook
authorAmir Goldstein <amir73il@gmail.com>
Wed, 22 Nov 2023 12:27:07 +0000 (14:27 +0200)
committerChristian Brauner <brauner@kernel.org>
Fri, 24 Nov 2023 08:22:28 +0000 (09:22 +0100)
commit2f4d8ad82511a336f8a805e3759c5189a25bb286
tree3a281c85d9d272663b40e913936e42a31a607e94
parent0b5263d12aed0437c1bdb7ba0be27437fc12c274
btrfs: move file_start_write() to after permission hook

In vfs code, file_start_write() is usually called after the permission
hook in rw_verify_area().  btrfs_ioctl_encoded_write() in an exception
to this rule.

Move file_start_write() to after the rw_verify_area() check in encoded
write to make the permission hook "start-write-safe".

This is needed for fanotify "pre content" events.

Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Link: https://lore.kernel.org/r/20231122122715.2561213-9-amir73il@gmail.com
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/btrfs/ioctl.c