]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core.git/commit
base.bbclass: fix RRECOMMENDS extend issue for multilib
authorChangqing Li <changqing.li@windriver.com>
Tue, 10 Dec 2024 06:24:55 +0000 (14:24 +0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 12 Dec 2024 12:59:32 +0000 (12:59 +0000)
commit2f539a1318a80d3ad5d0d43a9ba4070465e402af
tree5c73d69ab5ba136d17e3fc552e1bec4d3d963ccd
parent516c8e8f722ed0eb85a715a23b5e68d05abe9275
base.bbclass: fix RRECOMMENDS extend issue for multilib

During handle PACKAGECONFIG, DEPENDS/RDEPENDS/RRECOMMENDS is appended by
calling function appendVar according to the PACKAGECONFIG setting:
PACKAGECONFIG[f1] = "\
    --with-f1, \
    --without-f1, \
    build-deps-for-f1, \
    runtime-deps-for-f1, \
    runtime-recommends-for-f1, \
    packageconfig-conflicts-for-f1"

[snip of base.bbclass]
 pkgconfigflags = d.getVarFlags("PACKAGECONFIG") or {}
    if pkgconfigflags:
       ...
       appendVar('DEPENDS', extradeps)
       appendVar('RDEPENDS:${PN}', extrardeps)
       appendVar('RRECOMMENDS:${PN}', extrarrecs)
       ...
[snip of base.bbclass]

After following commit in meta-oe,
[fe3ba7ac5c cryptsetup: demote udev runtime dependency to recommendation]

'udev lvm2' changed from RDEPENDS to RRECOMMENDS, but RRECOMMENDS is not
handled in this process, and causes following error:
$bitbake lib32-cryptsetup
ERROR: QA Issue: lib32-cryptsetup package lib32-cryptsetup - suspicious values 'udev lvm2' in RRECOMMENDS [multilib]

In layer openembedded-core, we do have very few recipes that have
runtime-recommends-for-f1 in PACKAGECONFIG setting, but f1 is not
enabled in PACKAGECONFIGS, so not report error when multilib is enabled.

Signed-off-by: Changqing Li <changqing.li@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes-global/base.bbclass