]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
Revert "Call target_can_do_single_step from maybe_software_singlestep"
authorTom Tromey <tromey@adacore.com>
Wed, 6 Aug 2025 13:14:56 +0000 (07:14 -0600)
committerTom Tromey <tromey@adacore.com>
Wed, 6 Aug 2025 13:22:11 +0000 (07:22 -0600)
commit2f6db3e2e77d7e10b407fb43b13a985e9b4211ed
tree463df82c189fa6e074a078299a5d0e57f636de95
parentc2729c37f10af09126b2916215cae425ae724f55
Revert "Call target_can_do_single_step from maybe_software_singlestep"

This reverts commit 14de1447c9c52c1bfc52588f8652836f66ac6c47.

An automated tester said that this patch caused a regression on
aarch64:

FAIL: gdb.arch/aarch64-atomic-inst.exp: Step through the ldxr/stxr sequence (timeout)

I looked into it a bit yesterday but couldn't see an obvious problem;
and it's somewhat of a pain to try to debug it at the moment.

Tom de Vries also noticed this and filed it in bugzilla.  So, I'm
backing the patch out until I can port the failing test to the AdaCore
internal test suite in order to find out what went wrong.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28440
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33255
gdb/arm-linux-tdep.c
gdb/breakpoint.c
gdb/breakpoint.h
gdb/gdbarch-gen.h
gdb/gdbarch_components.py
gdb/infrun.c
gdb/record-full.c