]> git.ipfire.org Git - thirdparty/squid.git/commit
Fix r14945: Fixed Write.cc:41 "!ccb->active()" assertion.
authorChristos Tsantilas <chtsanti@users.sourceforge.net>
Thu, 17 Nov 2016 10:13:41 +0000 (12:13 +0200)
committerChristos Tsantilas <chtsanti@users.sourceforge.net>
Thu, 17 Nov 2016 10:13:41 +0000 (12:13 +0200)
commit2f97ab10f665ecfc06323f0b5cb5fcd7d0f1a103
tree4ed25369aebc113bbc35dd625a241f537cb0b12a
parent7686b9a3787c781e8785b9b768d07832d56be968
Fix r14945:  Fixed Write.cc:41 "!ccb->active()" assertion.

The r14945 patch has a major bug:
 When the Http::One::Server::writeControlMsgAndCall fails to write the control
message, schedules a Comm::Write callback using just a ScheduleCallHere command.
The callback called withtout the CommIoCbParams details and squid is crashes.

This patch fixes the ConnStateData::writeControlMsgAndCall to return false if it
fails to write the control message and allow the caller to handle the failure.

This is a Measurement Factory project
src/HttpControlMsg.cc
src/HttpControlMsg.h
src/client_side.cc
src/client_side.h
src/servers/FtpServer.cc
src/servers/FtpServer.h
src/servers/Http1Server.cc
src/servers/Http1Server.h
src/tests/stub_HttpControlMsg.cc