]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ipv6: ioam: block BH from ioam6_output()
authorEric Dumazet <edumazet@google.com>
Fri, 31 May 2024 13:26:32 +0000 (13:26 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 4 Jun 2024 01:50:08 +0000 (18:50 -0700)
commit2fe40483ec257de2a0d819ef88e3e76c7e261319
tree97a6c57c63ab893b3bf05825d7c9b3bb23927a71
parentffbe335b8d471f79b259e950cb20999700670456
ipv6: ioam: block BH from ioam6_output()

As explained in commit 1378817486d6 ("tipc: block BH
before using dst_cache"), net/core/dst_cache.c
helpers need to be called with BH disabled.

Disabling preemption in ioam6_output() is not good enough,
because ioam6_output() is called from process context,
lwtunnel_output() only uses rcu_read_lock().

We might be interrupted by a softirq, re-enter ioam6_output()
and corrupt dst_cache data structures.

Fix the race by using local_bh_disable() instead of
preempt_disable().

Fixes: 8cb3bf8bff3c ("ipv6: ioam: Add support for the ip6ip6 encapsulation")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Justin Iurman <justin.iurman@uliege.be>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Link: https://lore.kernel.org/r/20240531132636.2637995-2-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv6/ioam6_iptunnel.c