]> git.ipfire.org Git - thirdparty/glibc.git/commit
ldbl-128ibm-compat: Add *cvt functions
authorGabriel F. T. Gomes <gabrielftg@linux.ibm.com>
Thu, 11 Jul 2019 14:48:24 +0000 (11:48 -0300)
committerGabriel F. T. Gomes <gabrielftg@linux.ibm.com>
Mon, 23 Dec 2019 19:32:20 +0000 (16:32 -0300)
commit3021e781783d6fe12de4697b0d98957bc911cad3
treee2160e9c74cc5343f69b42cf6a1ee3f5fad9a11e
parentdce425341171ec5784c87165e23883630971bd97
ldbl-128ibm-compat: Add *cvt functions

This patch adds IEEE long double versions of q*cvt* functions for
powerpc64le.  Unlike all other long double to/from string conversion
functions, these do not rely on internal functions that can take
floating-point numbers with different formats and act on them
accordingly, instead, the related files are rebuilt with the
-mabi=ieeelongdouble compiler flag set.

Having -mabi=ieeelongdouble passed to the compiler causes the object
files to be marked with a .gnu_attribute that is incompatible with the
.gnu_attribute in files built with -mabi=ibmlongdouble (the default).
The difference causes error messages similar to the following:

  ld: libc_pic.a(s_isinfl.os) uses IBM long double,
      libc_pic.a(ieee128-qefgcvt_r.os) uses IEEE long double.
  collect2: error: ld returned 1 exit status
  make[2]: *** [../Makerules:649: libc_pic.os] Error 1

Although this warning is useful in other situations, the library
actually needs to have functions with different long double formats, so
.gnu_attribute generation is explicitly disabled for these files with
the use of -mno-gnu-attribute.

Tested for powerpc64le on the branch that actually enables the
sysdeps/ieee754/ldbl-128ibm-compat for powerpc64le.

Reviewed-by: Paul E. Murphy <murphyp@linux.ibm.com>
misc/efgcvt-template.c
misc/efgcvt_r-template.c
sysdeps/ieee754/ldbl-128ibm-compat/Makefile
sysdeps/ieee754/ldbl-128ibm-compat/Versions
sysdeps/ieee754/ldbl-128ibm-compat/ieee128-qefgcvt.c [new file with mode: 0644]
sysdeps/ieee754/ldbl-128ibm-compat/ieee128-qefgcvt_r.c [new file with mode: 0644]