]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commit
Don't link on_connect to first_connect event handler
authorMike Bayer <mike_mp@zzzcomputing.com>
Fri, 7 Aug 2020 18:51:33 +0000 (14:51 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Fri, 7 Aug 2020 22:01:49 +0000 (18:01 -0400)
commit302e8dee82718df6c3a46de4c5283bdae51a650a
tree0df6953aba01b6ff72a7094ff0887d11c4a700f0
parent40d64f3a525b14272b7354c72d7f84f6b00796f9
Don't link on_connect to first_connect event handler

Adjusted the dialect initialization process such that the
:meth:`_engine.Dialect.on_connect` is not called a second time on the first
connection.   The hook is called first, then the
:meth:`_engine.Dialect.initialize` is called if that connection is the
first for that dialect, then no more events are called.   This eliminates
the two calls to the "on_connect" function which can produce very difficult
debugging situations.

Fixes: #5497
Change-Id: Icefc2e884e30ee7b4ac84b99dc54bf992a6085e3
doc/build/changelog/unreleased_14/5497.rst [new file with mode: 0644]
lib/sqlalchemy/engine/create.py
lib/sqlalchemy/engine/default.py
lib/sqlalchemy/engine/interfaces.py
lib/sqlalchemy/testing/engines.py
test/engine/test_execute.py