]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
windows-nat: Remove SO_NAME_MAX_PATH_SIZE limit
authorPedro Alves <pedro@palves.net>
Fri, 22 Mar 2024 19:46:59 +0000 (19:46 +0000)
committerPedro Alves <pedro@palves.net>
Fri, 22 Mar 2024 19:46:59 +0000 (19:46 +0000)
commit30512efab1478ece80cf98d00eb70681afaf7412
treea751d6cbf51742b6f9d411ae69b34a7330a36005
parent092ff48583a1bbc1c4c5ca4edbf23c2d8c4a356b
windows-nat: Remove SO_NAME_MAX_PATH_SIZE limit

There is no need to limit shared library path sizes to
SO_NAME_MAX_PATH_SIZE nowadays.  windows_solib::name and
windows_solib::original_name are std::strings nowadays, and so are
solib::so_name and solib::so_original_name in the core solib code.

This commit reworks the code to remove that limit.  This also fixes a
leak where we were not releasing 'rname' in the realpath branch if the
'rname' string was larger than SO_NAME_MAX_PATH_SIZE.

Note: I tested the cygwin_conv_path with a manual hack to force that
path, and then stepping through the code.  You only get to that path
if Windows doesn't report an absolute path for ntdll.dll, and on my
machine (running Windows 10), it always does.

Approved-By: John Baldwin <jhb@FreeBSD.org>
Change-Id: I79e9862d5a7646eebfef7ab5b05b96318a7ca0c5
gdb/windows-nat.c