]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Re-forbid underscore in positional parameters
authorPeter Eisentraut <peter@eisentraut.org>
Wed, 15 May 2024 11:49:41 +0000 (13:49 +0200)
committerPeter Eisentraut <peter@eisentraut.org>
Wed, 15 May 2024 11:54:00 +0000 (13:54 +0200)
commit315661ecafbcbb23116cceea2ea80657d7763af0
treea810b2f543a15be0e9493233faf712bf72e63c62
parent987ab19ec9260618b36c186e0777f0bd43b8ded1
Re-forbid underscore in positional parameters

Underscores were added to numeric literals in faff8f8e47.  This change
also affected the positional parameters (e.g., $1) rule, which uses
the same production for its digits.  But this did not actually work,
because the digits for parameters are processed using atol(), which
does not handle underscores and ignores whatever it cannot parse.

The underscores notation is probably not useful for positional
parameters, so for simplicity revert that rule to its old form that
only accepts digits 0-9.

Author: Erik Wienhold <ewie@ewie.name>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://www.postgresql.org/message-id/flat/5d216d1c-91f6-4cbe-95e2-b4cbd930520c%40ewie.name
src/backend/parser/scan.l
src/fe_utils/psqlscan.l
src/interfaces/ecpg/preproc/pgc.l
src/test/regress/expected/numerology.out
src/test/regress/sql/numerology.sql