]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
bpo-40791: Make compare_digest more constant-time. (GH-20444)
authorDevin Jeanpierre <jeanpierreda@google.com>
Sat, 21 Nov 2020 08:55:23 +0000 (01:55 -0700)
committerGitHub <noreply@github.com>
Sat, 21 Nov 2020 08:55:23 +0000 (00:55 -0800)
commit31729366e2bc09632e78f3896dbce0ae64914f28
tree0596a25a57302928a432ff81662d42141bfbc391
parentaa3a3521cef3998d4f9e7f7ff721163b6e3e5f39
bpo-40791: Make compare_digest more constant-time. (GH-20444)

* bpo-40791: Make compare_digest more constant-time.

The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization.

(This is change #1 from https://bugs.python.org/issue40791 .)
Misc/NEWS.d/next/Security/2020-05-28-06-06-47.bpo-40791.QGZClX.rst [new file with mode: 0644]
Modules/_operator.c