]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Fix possible access of uninitialized pipe handles
authorSelva Nair <selva.nair@gmail.com>
Thu, 20 Feb 2020 01:56:43 +0000 (20:56 -0500)
committerDavid Sommerseth <davids@openvpn.net>
Thu, 20 Feb 2020 17:53:22 +0000 (18:53 +0100)
commit32723d29b2775d63d3fe329d017e7a08e0cdcb72
tree4216ce2d86c34dc426809ae1a7a733e7fe16576c
parente1f7d7885752ac3a0279ecc7e31ccee2af40fbe4
Fix possible access of uninitialized pipe handles

Compile time warning for openvpnserv.exe
interactive.c: In function ‘RunOpenvpn’:
interactive.c:160:27: warning: ‘svc_pipe’ may be used uninitialized in
this function [-Wmaybe-uninitialized]

When RunOpenvpn exits early due to errors, uninitialized svc_pipe and
ovpn_pipe vars could get passed to CloseHandleEx(). Fix by initializing
to NULL.

Signed-off-by: Selva Nair <selva.nair@gmail.com>
Acked-by: Lev Stipakov <lstipakov@gmail.com>
Message-Id: <1582163803-3342-1-git-send-email-selva.nair@gmail.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg19480.html
Signed-off-by: David Sommerseth <davids@openvpn.net>
src/openvpnserv/interactive.c