]> git.ipfire.org Git - people/arne_f/kernel.git/commit
scripts/coccinelle/misc/bugon.cocci: update bug_on conversion warning
authorFabian Frederick <fabf@skynet.be>
Thu, 9 Apr 2015 20:58:04 +0000 (22:58 +0200)
committerMichal Marek <mmarek@suse.cz>
Wed, 15 Apr 2015 12:21:31 +0000 (14:21 +0200)
commit33236415ece63d5689411f3ddb676eeb93af2698
treea2f62547e4d316850af24653761ed650bb269993
parent99b2cdde83726a89daadbfd1264fb9a3b91eed0b
scripts/coccinelle/misc/bugon.cocci: update bug_on conversion warning

if()/BUG conversion to BUG_ON must be avoided when there's side effect
in condition. The reason being BUG_ON won't execute the condition when
CONFIG_BUG is not defined.

Inspired-by: J. Bruce Fields <bfields@fieldses.org>
Suggested-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Michal Marek <mmarek@suse.cz>
scripts/coccinelle/misc/bugon.cocci