]> git.ipfire.org Git - thirdparty/qemu.git/commit
pnv/xive: Fix possible undefined shift error in group size calculation
authorNicholas Piggin <npiggin@gmail.com>
Mon, 17 Mar 2025 03:18:29 +0000 (13:18 +1000)
committerNicholas Piggin <npiggin@gmail.com>
Thu, 20 Mar 2025 09:55:13 +0000 (19:55 +1000)
commit344921309d933547974c2e85c52e2294513d9c45
tree0e2b681cf419109808fb03c95c4b1be9392899dc
parent033a5649b45690d09bde5cdf15cb83453f6ac811
pnv/xive: Fix possible undefined shift error in group size calculation

Coverity discovered a potential shift overflow in group size calculation
in the case of a guest error. Add checks and logs to ensure a issues are
caught.

Make the group and crowd error checking code more similar to one another
while here.

Resolves: Coverity CID 1593724
Fixes: 9cb7f6ebed60 ("ppc/xive2: Support group-matching when looking for target")
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
hw/intc/xive.c
hw/intc/xive2.c