]> git.ipfire.org Git - thirdparty/qemu.git/commit
block-backend: Always notify on blk_eject
authorJohn Snow <jsnow@redhat.com>
Mon, 14 Nov 2016 16:15:54 +0000 (11:15 -0500)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Wed, 21 Dec 2016 15:59:57 +0000 (09:59 -0600)
commit345f1cd9f6e4f156c7af0098b3d220305037f227
tree6beff445cbd5ae4e54e0180dd0fbe22f1ecc9c0c
parent8d5f2a75702b1975f8f2f2b866bde0b60493e3c3
block-backend: Always notify on blk_eject

blk_eject is only used by scsi-disk and atapi, and in both cases we
only attempt to invoke blk_eject if we have a bona-fide change in
tray state.

The "issue" here is that the tray state does not generate a QMP event
unless there is a medium/BDS attached to the device, so if libvirt et al
are waiting for a tray event to occur from an empty-but-closed drive,
software opening that drive will not emit an event and libvirt will
wait forever.

Change this by modifying blk_eject to always emit an event, instead of
conditionally on a "real" backend eject.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1373264
Reported-by: Peter Krempa <pkrempa@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Message-id: 1478553214-497-2-git-send-email-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
(cherry picked from commit c47ee043dc2cc85da710e87524144a720598c096)

* dropped functional depedenecy on 2d76e724

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
block/block-backend.c