]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
dpll: zl3073x: Fix double free in zl3073x_devlink_flash_update()
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 25 Sep 2025 13:28:13 +0000 (16:28 +0300)
committerJakub Kicinski <kuba@kernel.org>
Fri, 26 Sep 2025 22:23:55 +0000 (15:23 -0700)
commit347afa39042728267550fa7a5ab5e9af52671add
treee29c241c89b781a5b470504ccb8b6418075bf1b9
parent81dcfdd21dbd7067068c7c341ee448c3f0d6f115
dpll: zl3073x: Fix double free in zl3073x_devlink_flash_update()

The zl3073x_devlink_flash_prepare() function calls zl3073x_fw_free() and
the caller, zl3073x_devlink_flash_update(), also calls that same free
function so it leads to a double free.  Delete the extra free.

Fixes: a1e891fe4ae8 ("dpll: zl3073x: Implement devlink flash callback")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Ivan Vecera <ivecera@redhat.com>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Link: https://patch.msgid.link/aNVDbcIQq4RmU_fl@stanley.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/dpll/zl3073x/devlink.c