]> git.ipfire.org Git - thirdparty/iptables.git/commit
arptables-nft: remove ARPT_INV flags usage
authorFlorian Westphal <fw@strlen.de>
Fri, 3 Nov 2023 16:33:22 +0000 (17:33 +0100)
committerPhil Sutter <phil@nwl.cc>
Fri, 3 Nov 2023 20:46:10 +0000 (21:46 +0100)
commit3493d40cbba9dbfc00018b419241c93646a97a68
treea575c11906e1d778b34c0152f1ce46710750df23
parent7b9eb746f112f4f5677a6206013497c8233ffae8
arptables-nft: remove ARPT_INV flags usage

ARPT_ and IPT_INV flags are not interchangeable, e.g.:
define IPT_INV_SRCDEVADDR 0x0080
define ARPT_INV_SRCDEVADDR 0x0010

as these flags can be tested by libarp_foo.so such checks can yield
incorrect results.

Because arptables-nft uses existing code, e.g. xt_mark, it makes
sense to unify this completely by converting the last users of
ARPT_INV_ constants.

Note that arptables-legacy does not do run-time module loading via
dlopen(). Functionaliy implemented by "extensions" in the
arptables-legacy git tree are built-in, so this doesn't break
arptables-legacy binaries.

Fixes: 44457c080590 ("xtables-arp: Don't use ARPT_INV_*")
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Phil Sutter <phil@nwl.cc>
extensions/libarpt_mangle.c
iptables/nft-arp.c
iptables/xshared.h