]> git.ipfire.org Git - thirdparty/qemu.git/commit
meson: use config_base_arch for target libraries
authorPierrick Bouvier <pierrick.bouvier@linaro.org>
Mon, 2 Jun 2025 23:38:01 +0000 (16:38 -0700)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 3 Jun 2025 20:42:46 +0000 (22:42 +0200)
commit34d697f427d853e4cc14bb369b9134fe4b663cda
treedf133100255ccb5b7342a71eac488e6e115787aa
parent91084f3b44b1da4935eec85b79c1f97d1c140ada
meson: use config_base_arch for target libraries

Fixed commit introduced common dependencies for target libraries. Alas,
it wrongly reused the 'target' variable, which was previously set from
another loop.

Thus, some dependencies were missing depending on order of target list,
as found here [1].

The fix is to use the correct config_base_arch instead.
Kudos to Thomas Huth who had this right, before I reimplement it, and
introduce this bug.

[1] https://lore.kernel.org/qemu-devel/c54469ce-0385-4aea-b345-47711e9e61de@linaro.org/

Fixes: 4fb54de823e9 (meson: build target libraries with common dependencies)
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Tested-by: Cédric Le Goater <clg@redhat.com>
Link: https://lore.kernel.org/r/20250602233801.2699961-1-pierrick.bouvier@linaro.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
meson.build