]> git.ipfire.org Git - thirdparty/iptables.git/commit
Revert "xshared: Print protocol numbers if --numeric was given"
authorPhil Sutter <phil@nwl.cc>
Wed, 10 Jan 2024 13:08:58 +0000 (14:08 +0100)
committerPhil Sutter <phil@nwl.cc>
Tue, 6 Feb 2024 23:25:03 +0000 (00:25 +0100)
commit34f085b1607364f4eaded1140060dcaf965a2649
treee879529b9648c1fcb8aaa36a27118e32f3ab7082
parenta392cf0e9b11b01352d02e81fbd5ad4da49bce94
Revert "xshared: Print protocol numbers if --numeric was given"

This reverts commit da8ecc62dd765b15df84c3aa6b83dcb7a81d4ffa.

The patch's original intention is not entirely clear anymore. If it was
to reduce delays involved by calling getprotobynumber() though, commit
b6196c7504d4d ("xshared: Prefer xtables_chain_protos lookup over
getprotoent") avoids those if --numeric flag was given already. Also,
this numeric protocol output did not cover iptables-save which is a more
relevant candidate for such optimizations anyway.

Closes: https://bugzilla.netfilter.org/show_bug.cgi?id=1729
Signed-off-by: Phil Sutter <phil@nwl.cc>
iptables/tests/shell/testcases/ip6tables/0002-verbose-output_0
iptables/tests/shell/testcases/ipt-restore/0011-noflush-empty-line_0
iptables/tests/shell/testcases/iptables/0002-verbose-output_0
iptables/xshared.c