]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
irqchip/gic-v3-its: Don't enable interrupts in its_irq_set_vcpu_affinity()
authorTomas Krcka <krckatom@amazon.de>
Mon, 30 Dec 2024 15:08:25 +0000 (15:08 +0000)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 15 Jan 2025 08:42:45 +0000 (09:42 +0100)
commit35cb2c6ce7da545f3b5cb1e6473ad7c3a6f08310
treeb46e2d9010ef83670cb3b72b180fa6563683a56a
parent0d62a49ab55c99e8deb4593b8d9f923de1ab5c18
irqchip/gic-v3-its: Don't enable interrupts in its_irq_set_vcpu_affinity()

The following call-chain leads to enabling interrupts in a nested interrupt
disabled section:

irq_set_vcpu_affinity()
  irq_get_desc_lock()
     raw_spin_lock_irqsave()   <--- Disable interrupts
  its_irq_set_vcpu_affinity()
     guard(raw_spinlock_irq)   <--- Enables interrupts when leaving the guard()
  irq_put_desc_unlock()        <--- Warns because interrupts are enabled

This was broken in commit b97e8a2f7130, which replaced the original
raw_spin_[un]lock() pair with guard(raw_spinlock_irq).

Fix the issue by using guard(raw_spinlock).

[ tglx: Massaged change log ]

Fixes: b97e8a2f7130 ("irqchip/gic-v3-its: Fix potential race condition in its_vlpi_prop_update()")
Signed-off-by: Tomas Krcka <krckatom@amazon.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Marc Zyngier <maz@kernel.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/all/20241230150825.62894-1-krckatom@amazon.de
drivers/irqchip/irq-gic-v3-its.c