]> git.ipfire.org Git - people/arne_f/kernel.git/commit
net: macb: Add a NULL check on desc_ptp
authorHarini Katakam <harini.katakam@xilinx.com>
Tue, 24 Aug 2021 10:02:09 +0000 (15:32 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 Sep 2021 06:49:00 +0000 (08:49 +0200)
commit35f223cb21b1cb75175e736cb5b1b2615ae6d342
tree8bcc5881db0afb45b3f2a8a571cbfff73a5eeab8
parentcf50d02e474be9f0d6f2fed9aecf4dc90cc6e729
net: macb: Add a NULL check on desc_ptp

[ Upstream commit 85520079afce885b80647fbd0d13d8f03d057167 ]

macb_ptp_desc will not return NULL under most circumstances with correct
Kconfig and IP design config register. But for the sake of the extreme
corner case, check for NULL when using the helper. In case of rx_tstamp,
no action is necessary except to return (similar to timestamp disabled)
and warn. In case of TX, return -EINVAL to let the skb be free. Perform
this check before marking skb in progress.
Fixes coverity warning:
(4) Event dereference:
Dereferencing a null pointer "desc_ptp"

Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/cadence/macb_ptp.c