]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
[gdb/testsuite] Set interactive-mode to on
authorTom de Vries <tdevries@suse.de>
Tue, 17 Jun 2025 06:28:50 +0000 (08:28 +0200)
committerTom de Vries <tdevries@suse.de>
Tue, 17 Jun 2025 06:28:50 +0000 (08:28 +0200)
commit3622898cf318697604caba330884c26c1a043265
tree5c8cd1599ffcfe60852f9e3bad51948717e5aa33
parent7e1964f9c61c2a508d955ce603800cb894ac937f
[gdb/testsuite] Set interactive-mode to on

With MSYS2 and test-case gdb.ada/assign_1.exp, we get:
...
(gdb) dir^M
Reinitialize source path to empty? (y or n) \
  [answered Y; input not from terminal]^M^M
Source directories searched: $cdir;$cwd^M^M
(gdb)
...

GDB automatically answers the query, because interactive-mode is off:
...
(gdb) show interactive-mode^M
Debugger's interactive mode is auto (currently off).^M^M
...

The correct value is on, because GDB was started in a terminal.

For some reason, the auto value of interactive-mode is off instead.  According
to this patch [1], gdb doesn't recognize the pipes used by DejaGnu testsuite
as an interactive setup.

Fix this by adding "set interactive-mode on" to INTERNAL_GDBFLAGS, such that
we get:
...
(gdb) dir^M
Reinitialize source path to empty? (y or n) y^M
Source directories searched: $cdir;$cwd^M^M
(gdb)
...
and no longer need fixes like commit be740e7cc62 ("testsuite: skip
confirmation in 'gdb_reinitialize_dir'")

The fix is essentially the same as in aforementioned patch.

For consistency, we apply the fix for all platforms.

Co-Authored-By: Pierre Muller <muller@sourceware.org>
Approved-By: Tom Tromey <tom@tromey.com>
[1] https://sourceware.org/legacy-ml/gdb-patches/2013-09/msg00940.html
gdb/testsuite/lib/gdb.exp