]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
[gdb/python] Eliminate catch(...) in type_to_type_object
authorTom de Vries <tdevries@suse.de>
Thu, 22 Aug 2024 07:49:53 +0000 (09:49 +0200)
committerTom de Vries <tdevries@suse.de>
Thu, 22 Aug 2024 07:49:53 +0000 (09:49 +0200)
commit365b32b9c7792cb5fb67c658ea28b1c3a7a8ef71
treeba299be3bbeba176ed60e06c8519a9757f6d894d
parent78125417227bd3f3765ba52d04066f8607d62f44
[gdb/python] Eliminate catch(...) in type_to_type_object

In type_to_type_object we have:
...
  try
    {
      if (type->is_stub ())
type = check_typedef (type);
    }
  catch (...)
    {
      /* Just ignore failures in check_typedef.  */
    }
...

The catch is supposed to ignore gdb_exception_error, but it ignores any
exception.

Fix that by only ignoring gdb_exception_error, and handling
gdb_exception_quit / gdb_exception_forced_quit using GDB_PY_HANDLE_EXCEPTION.

Tested on x86_64-linux.

Approved-By: Tom Tromey <tom@tromey.com>
gdb/python/py-type.c