]> git.ipfire.org Git - people/ms/linux.git/commit
ALSA: control: Make sure that id->index does not overflow
authorLars-Peter Clausen <lars@metafoo.de>
Wed, 18 Jun 2014 11:32:35 +0000 (13:32 +0200)
committerWilly Tarreau <w@1wt.eu>
Sun, 23 Nov 2014 09:55:34 +0000 (10:55 +0100)
commit365c843b9e11bc85cacd8fe3d93965734297f35b
treeccc20482f4bacf91689e698a3daa2fbc2ea00faa
parent9ff558c6afe440afa94ef870322386cc06541843
ALSA: control: Make sure that id->index does not overflow

The ALSA control code expects that the range of assigned indices to a control is
continuous and does not overflow. Currently there are no checks to enforce this.
If a control with a overflowing index range is created that control becomes
effectively inaccessible and unremovable since snd_ctl_find_id() will not be
able to find it. This patch adds a check that makes sure that controls with a
overflowing index range can not be created.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Jaroslav Kysela <perex@perex.cz>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
(cherry picked from commit 883a1d49f0d77d30012f114b2e19fc141beb3e8e)
[wt: part 1 of CVE-2014-4656 fix]
Signed-off-by: Willy Tarreau <w@1wt.eu>
sound/core/control.c