]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Ignore invalidated slots while computing oldest catalog Xmin
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 22 Nov 2022 09:56:07 +0000 (10:56 +0100)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 22 Nov 2022 09:56:07 +0000 (10:56 +0100)
commit36eeb37cd611c0a0bfb5743d9ddbef8f04fc87f3
treeb7c02343061154d38b9a51a29ab0ff748cf21580
parent0e3215292f48f3e204402a07140322b63a30de36
Ignore invalidated slots while computing oldest catalog Xmin

Once a logical slot has acquired a catalog_xmin, it doesn't let go of
it, even when invalidated by exceeding the max_slot_wal_keep_size, which
means that dead catalog tuples are not removed by vacuum anymore since
the point is invalidated, until the slot is dropped.  This could be
catastrophic if catalog churn is high.

Change the computation of Xmin to ignore invalidated slots,
to prevent dead rows from accumulating.

Backpatch to 13, where slot invalidation appeared.

Author: Sirisha Chamarthi <sirichamarthi22@gmail.com>
Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Discussion: https://postgr.es/m/CAKrAKeUEDeqquN9vwzNeG-CN8wuVsfRYbeOUV9qKO_RHok=j+g@mail.gmail.com
src/backend/replication/slot.c
src/backend/storage/ipc/procarray.c