]> git.ipfire.org Git - thirdparty/samba.git/commit
samba-tool visualise: expand set of --color switches
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Wed, 17 Aug 2022 01:15:15 +0000 (13:15 +1200)
committerDouglas Bagnall <dbagnall@samba.org>
Tue, 6 Sep 2022 21:12:36 +0000 (21:12 +0000)
commit37f92c6cc69b220439aef0c687c92a8e6baeb211
treee138df84a97568dcdfc3163e8b6ce9bcf925955d
parent664653b8d14cbe21c954d248b2bb5ef0d2d60043
samba-tool visualise: expand set of --color switches

To match convention, and elsewhere.

We can't easily use colour.is_colour_wanted() because we could (via
--output) be intending to write to a file that isn't open yet, so we
have no .isatty() to query.

Also, because --color-scheme implies --color (as documented in
--help), it trumps most 'auto' checks, but not NO_COLOR.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Joseph Sutton <josephsutton@catalyst.net.nz>
python/samba/netcmd/visualize.py
selftest/knownfail.d/samba-tool-visualize [deleted file]