]> git.ipfire.org Git - thirdparty/asterisk.git/commit
Fix broken reinvite glare scenario.
authorMark Michelson <mmichelson@digium.com>
Mon, 14 May 2012 19:16:36 +0000 (19:16 +0000)
committerMark Michelson <mmichelson@digium.com>
Mon, 14 May 2012 19:16:36 +0000 (19:16 +0000)
commit38099582c0e8ba76607cf93cd48e4c2c3e6193c9
treeb120cb6da0c59f68a4a1c075c080b06ac66288b5
parent66a9849c6b2aa27c7787958c51a68fb91c507376
Fix broken reinvite glare scenario.

To make a long story short, reinvite glares were broken
because Asterisk would invert the To and From headers
when ACKing a 491 response.

The reason was because the initreq of the dialog was being
changed to the incoming glared reinvite instead of being
set to the outgoing glared reinvite. This change has three
parts

* In handle_incoming, we never will reject an ACK because it
has a to-tag present, even if we think the request may be out
of dialog.
* In handle_request_invite, we do not change the initreq when
receiving a reinvite to which we will respond with a 491.
* In handle_request_invite, several superflous settings up
pendinginvite have been removed since this is dones automatically
by transmit_response_reliable

Review: https://reviewboard.asterisk.org/r/1911
........

Merged revisions 366389 from http://svn.asterisk.org/svn/asterisk/branches/1.8

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10@366390 65c4cc65-6c06-0410-ace0-fbb531ad65f3
channels/chan_sip.c