]> git.ipfire.org Git - thirdparty/qemu.git/commit
amd_iommu: Fix truncation of oldval in amdvi_writeq
authorEthan Milon <ethan.milon@eviden.com>
Tue, 17 Jun 2025 15:04:27 +0000 (15:04 +0000)
committerMichael Tokarev <mjt@tls.msk.ru>
Wed, 16 Jul 2025 13:14:16 +0000 (16:14 +0300)
commit385eb77f6051d265322782a6f53a89bca9967d61
tree872607ba9c90214198086113018981b6b40190f1
parentcae7315f45ae6662e193e7126959e775a6d49040
amd_iommu: Fix truncation of oldval in amdvi_writeq

The variable `oldval` was incorrectly declared as a 32-bit `uint32_t`.
This could lead to truncation and incorrect behavior where the upper
read-only 32 bits are significant.

Fix the type of `oldval` to match the return type of `ldq_le_p()`.

Cc: qemu-stable@nongnu.org
Fixes: d29a09ca6842 ("hw/i386: Introduce AMD IOMMU")
Signed-off-by: Ethan Milon <ethan.milon@eviden.com>
Message-Id: <20250617150427.20585-9-alejandro.j.jimenez@oracle.com>
Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
(cherry picked from commit 5788929e05e18ed5f76dc8ade4210f022c9ba5a1)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/i386/amd_iommu.c