]> git.ipfire.org Git - thirdparty/squid.git/commit
Prohibit fruitless modification of httpBuildRequestHeader flags parameter.
authorAlex Rousskov <rousskov@measurement-factory.com>
Tue, 14 Sep 2010 05:40:33 +0000 (23:40 -0600)
committerAlex Rousskov <rousskov@measurement-factory.com>
Tue, 14 Sep 2010 05:40:33 +0000 (23:40 -0600)
commit386c7842cbff563b2ed54878c28d555485001fb5
tree059dde55ffc1a6a411ccab4bb6da911e1558a70d
parent3d9b21dbdff0f1b27f3d973de81cef81b6845a25
Prohibit fruitless modification of httpBuildRequestHeader flags parameter.

HttpStateData::httpBuildRequestHeader is a static method, but it has a
parameter called flags, just like HttpStateData objects have a data member
called flags. Modifying that parameter "worked" but had no effect on the
caller's flags. Wasted a few good hours.

The parameter is "const" now, to prevent fruitless modification.

Also removed http_state_flags parameter from HttpStateData::buildRequestPrefix
which is not a static method and has access to the "real" flags member.

No runtime effect expected.

TODO: Rename HttpStateData::httpBuildRequestHeader to mark its static nature.
Does it belong to HttpStateData at all?
src/http.cc
src/http.h