]> git.ipfire.org Git - thirdparty/gcc.git/commit
c++: is_specialization_of_friend confusion [PR109923]
authorPatrick Palka <ppalka@redhat.com>
Sat, 3 Jun 2023 13:26:43 +0000 (09:26 -0400)
committerPatrick Palka <ppalka@redhat.com>
Sat, 3 Jun 2023 13:26:43 +0000 (09:26 -0400)
commit38af81df6aac11d49f9378d1c628ccc3c815c3ff
tree82b9ee008df9e6cb17f93154487bd8d134d711ed
parent23bee8508816297a9b2ab81a96aa0c79ac88ceba
c++: is_specialization_of_friend confusion [PR109923]

The check for a non-template member function of a class template in
is_specialization_of_friend is overbroad, and accidentally holds for a
non-template hidden friend too, which for the testcase below causes the
predicate to bogusly return true for

  decl = void non_templ_friend(A<int>, A<void>)
  friend_decl = void non_templ_friend(A<void>, A<void>)

This patch refines the check appropriately.

PR c++/109923

gcc/cp/ChangeLog:

* pt.cc (is_specialization_of_friend): Fix overbroad check for
a non-template member function of a class template.

gcc/testsuite/ChangeLog:

* g++.dg/template/friend79.C: New test.
gcc/cp/pt.cc
gcc/testsuite/g++.dg/template/friend79.C [new file with mode: 0644]