]> git.ipfire.org Git - thirdparty/linux.git/commit
io_uring/rw: fix downgraded mshot read
authorPavel Begunkov <asml.silence@gmail.com>
Sat, 28 Dec 2024 17:44:52 +0000 (17:44 +0000)
committerJens Axboe <axboe@kernel.dk>
Sat, 28 Dec 2024 20:13:22 +0000 (13:13 -0700)
commit38fc96a58ce40257aec79b32e9b310c86907c63c
treec7208b2aa74c109479f353f2dfbad47968493dc0
parente33ac68e5e21ec1292490dfe061e75c0dbdd3bd4
io_uring/rw: fix downgraded mshot read

The io-wq path can downgrade a multishot request to oneshot mode,
however io_read_mshot() doesn't handle that and would still post
multiple CQEs. That's not allowed, because io_req_post_cqe() requires
stricter context requirements.

The described can only happen with pollable files that don't support
FMODE_NOWAIT, which is an odd combination, so if even allowed it should
be fairly rare.

Cc: stable@vger.kernel.org
Reported-by: chase xd <sl1589472800@gmail.com>
Fixes: bee1d5becdf5b ("io_uring: disable io-wq execution of multishot NOWAIT requests")
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/c5c8c4a50a882fd581257b81bf52eee260ac29fd.1735407848.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring/rw.c