]> git.ipfire.org Git - thirdparty/qemu.git/commit
target/hppa: Fix PSW V-bit packaging in cpu_hppa_get for hppa64
authorHelge Deller <deller@gmx.de>
Tue, 3 Sep 2024 15:22:10 +0000 (17:22 +0200)
committerMichael Tokarev <mjt@tls.msk.ru>
Thu, 5 Sep 2024 19:59:09 +0000 (22:59 +0300)
commit3903049d124282f753afb891a533a0d9b8d277e0
treee8b2c8d6e23e89f8e6bf9bafd605acecd0cdbb33
parent9943ceb460b4ba49cc56453cddb67405d94e39e0
target/hppa: Fix PSW V-bit packaging in cpu_hppa_get for hppa64

While adding hppa64 support, the psw_v variable got extended from 32 to 64
bits.  So, when packaging the PSW-V bit from the psw_v variable for interrupt
processing, check bit 31 instead the 63th (sign) bit.

This fixes a hard to find Linux kernel boot issue where the loss of the PSW-V
bit due to an ITLB interruption in the middle of a series of ds/addc
instructions (from the divU milicode library) generated the wrong division
result and thus triggered a Linux kernel crash.

Link: https://lore.kernel.org/lkml/718b8afe-222f-4b3a-96d3-93af0e4ceff1@roeck-us.net/
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Helge Deller <deller@gmx.de>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Fixes: 931adff31478 ("target/hppa: Update cpu_hppa_get/put_psw for hppa64")
Cc: qemu-stable@nongnu.org # v8.2+
(cherry picked from commit ead5078cf1a5f11d16e3e8462154c859620bcc7e)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
(Mjt: context fixup in target/hppa/helper.c due to lack of
 v9.0.0-688-gebc9401a4067 "target/hppa: Split PSW X and B into their own field")
target/hppa/cpu.h
target/hppa/helper.c