]> git.ipfire.org Git - thirdparty/qemu.git/commit
block-backend: Set werror/rerror defaults in blk_new()
authorKevin Wolf <kwolf@redhat.com>
Fri, 28 Sep 2018 09:11:50 +0000 (11:11 +0200)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Wed, 27 Mar 2019 05:58:34 +0000 (00:58 -0500)
commit399814e1a17572da006bad487825748fc87552cb
tree19c1e6aaed09f7b447146e00b199297b152b90d9
parentce2c15fdafa18bb6262dc79e527ebdb78a9671df
block-backend: Set werror/rerror defaults in blk_new()

Currently, the default values for werror and rerror have to be set
explicitly with blk_set_on_error() by the callers of blk_new(). The only
caller actually doing this is blockdev_init(), which is called for
BlockBackends created using -drive.

In particular, anonymous BlockBackends created with
-device ...,drive=<node-name> didn't get the correct default set and
instead defaulted to the integer value 0 (= BLOCKDEV_ON_ERROR_REPORT).
This is the intended default for rerror anyway, but the default for
werror should be BLOCKDEV_ON_ERROR_ENOSPC.

Set the defaults in blk_new() instead so that they apply no matter what
way the BlockBackend was created.

Cc: qemu-stable@nongnu.org
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
(cherry picked from commit cb53460b708db3617ab73248374d071d5552c263)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
block/block-backend.c
tests/qemu-iotests/067.out